Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom spacing to line alignment rule #740

Merged
merged 8 commits into from
May 17, 2021
Merged

Add custom spacing to line alignment rule #740

merged 8 commits into from
May 17, 2021

Conversation

renatho
Copy link
Contributor

@renatho renatho commented May 16, 2021

Fixes #732

It introduces the customSpacings option to the line alignment rule. You can use something like:

        customSpacings: {
          postDelimiter: 2,
          postTag: 3,
          postType: 2,
        },

If the spacing is not defined, it uses 1 by default.

brettz9
brettz9 requested changes May 17, 2021
View reviewed changes
Copy link
Collaborator

@brettz9 brettz9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comments, everything looks great to me from here... Thanks!

test/rules/assertions/checkLineAlignment.js Show resolved Hide resolved
@renatho
Copy link
Contributor Author

renatho commented May 17, 2021

Thank you for your review @brettz9! The changes were added. =)

@brettz9 brettz9 merged commit 3da3d31 into gajus:master May 17, 2021
@brettz9
Copy link
Collaborator

brettz9 commented May 17, 2021

I got the commit message fine I think, but Git is not finding the remote refs to complete the CI and release process. Trying to figure out how to resolve.

brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this pull request May 17, 2021
@brettz9
Revert "feat: add custom spacing to line alignment rule (gajus#740); f…
8e6e102 
…ixes gajus#732"

This reverts commit 3da3d31.
brettz9 added a commit to brettz9/eslint-plugin-jsdoc that referenced this pull request May 17, 2021
@brettz9
Revert "Revert "feat: add custom spacing to line alignment rule (gaju…
1932b5b 
…s#740); fixes gajus#732""

This reverts commit 8e6e102.
@gajus
Copy link
Owner

gajus commented May 17, 2021

🎉 This PR is included in version 34.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettz9 brettz9 brettz9 requested changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsdoc/check-line-alignment option to take into account existing alignment
3 participants
@renatho @brettz9 @gajus